Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the instructions for updating licenses. #51297

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

chinmaygarde
Copy link
Member

  • Adds markdown formatting to better highlight the important bits.
  • Removes the bit about patch files not being valid because they are copied from the GitHub UI (we use LUCI now).
  • Add a shortcut for Mac to apply the patch from your pasteboard.

* Adds markdown formatting to better highlight the important bits.
* Removes the bit about patch files not being valid because they are copied from the GitHub UI (we use LUCI now).
* Add a shortcut for Mac to apply the patch from your pasteboard.
@chinmaygarde chinmaygarde requested a review from Hixie March 8, 2024 21:53
@chinmaygarde
Copy link
Member Author

The diff is pretty awful the read. You can view the rendered Markdown here.

Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde merged commit 8e78d3e into main Mar 8, 2024
23 checks passed
@chinmaygarde chinmaygarde deleted the reword_licenses_readme branch March 8, 2024 23:18
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 9, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 9, 2024
…144862)

flutter/engine@953927e...7541e90

2024-03-08 [email protected] [Impeller] implement mask blur for textures (flutter/engine#51183)
2024-03-08 [email protected] Don't rely on dart binary on PATH in run_test.py (flutter/engine#51302)
2024-03-08 [email protected] Mark the Flutter Views as focusable by setting a tabindex value. (flutter/engine#50876)
2024-03-08 [email protected] Update the instructions for updating licenses. (flutter/engine#51297)
2024-03-08 [email protected] Optimize overlays in CanvasKit (flutter/engine#47317)
2024-03-08 [email protected] Roll Fuchsia Linux SDK from 5Ra_AjCji-uR1GaX7... to lAV5jgp4796siOZgI... (flutter/engine#51296)
2024-03-08 [email protected] [Impeller] Add the KHR prefix to existing swapchain utilities. (flutter/engine#51295)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 5Ra_AjCji-uR to lAV5jgp4796s

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants